search

mariuz / flamerobin

FlameRobin is a database administration tool for Firebird RDBMS. Our goal is to build a tool that is: lightweight (small footprint, fast execution) cross-platform (Linux, Windows, Mac OS X, FreeBSD) dependent only on other Open Source software
http://flamerobin.org
MIT License
214 stars 66 forks source link

Rename all GENERATOR references to SEQUENCE #54

Open luronumen opened 4 years ago

luronumen commented 4 years ago

According to the https://firebirdsql.org/refdocs/langrefupd21-ddl-sequence.html documentation, SEQUENCE is the SQL-compliant term for what InterBase and Firebird have always called a GENERATOR and SEQUENCE is the recommended syntax from Firebird 2.0 onward.

Please rename all GENERATOR references to SEQUENCE:

PizzaProgram commented 4 years ago

Simply "renaming" would be NOT the best solution, since FlameRobin needs to be able to manipulate old databases too! So this could be either:

  1. automatic (based on installed engine + OSD version! ) or

  2. manually option settable per database at connection properties.

    _I prefer the 2th method, because personally I don't like the new format.
    GENID(...) is so nice short, fast, and easy to understand. The 1th method is harder to test. (Needs someone to install ALL kind of DB versions and try all kinds of old DBs with different ODS. )

arvanus commented 4 years ago

Hi @luronumen! Thanks for your effort posting the problems that you found, it's helping a lot. Please, keep posting any problem you find, the more info, the better!

About this issue: I think that unless it became unsupported in the next releases, there is a lot of other problems that are easier to fix before we can make effort changing a "cosmetic" suggested syntax. By the way, if there is an greater impact between using generator or sequence I really don't know!!

Anyway I still don't know FR code too well to change a thing like this without losing a lots of time, but off course that if someone can help, this patch will be welcome.

luronumen commented 4 years ago

I totally agree with you @arvanus ! Changing all references from GENERATOR to SEQUENCE can be very risky and can insert many side effects in FlameRobin. We better wait for the http://tracker.firebirdsql.org/browse/CORE-6298 to be fixed before working on this issue.

Let's first focus on fixing issues marked as a bug here in the project by reducing our list of open / pending bugs.

Best Regards, Luciano

Jdochoa commented 4 years ago

I'm work in change to sequences, this change include the support to: { CREATE | RECREATE } { SEQUENCE | GENERATOR } [ START WITH ] [ INCREMENT BY ]

luronumen commented 4 years ago

Thank you very much for your work and effort to keep FlameRobin up to date @Jdochoa! I really appreciate it!

luronumen commented 4 years ago

Please use the 5.11. SEQUENCE (GENERATOR) Language Reference for Firebird 2.5 to implement this feature.