search

mariuz / perl-dbd-firebird

Perl DBI driver for Firebird
15 stars 9 forks source link

Non interactive setup for tests with Makefile.PL, by default #16

Closed stefansbv closed 13 years ago

stefansbv commented 13 years ago

I made a comment on the "Integrate patches from fedora/mandriva downstream", but no one seems to noticed it, so i decided to make it a new issue.

The comment was: "Made some experimental changes in a new branch named newsetup. By default Makefile.PL uses env vars and default values to run as automatic as possible. And now there is also the old behavior with prompts, at request, with the -i[nteractive] command line option. ..."

Changes to the test system includes: All tests use the new 'tests-setup.pl' library. (Old ones used 'lib.pl', 'testlib.pl' and 'Firebird.dbtest'). Renamed some tests and deprecated other.

Makefile.PL has a default non interactive default behavior that, I think, is better for the CPAN testers, but preserves also the old behavior with prompts, at request, with the -i[nteractive] command line option.

Great work, is nice to see:

All tests successful.  Files=33, Tests=842, 52 wallclock secs ( 0.98 usr 0.15 sys + 9.99 cusr 1.37 csys = 12.49 CPU)
Result: PASS

Thank you, Stefan.

mariuz commented 13 years ago

I have noticed My vote is to apply your patch directly and in the future the firebird custom path for each distro can be added to the list of paths already added also i like your idea of -i :)

real-dam commented 13 years ago

I think CPAN Testers set AUTOMATIC_TESTING in their environment. Maybe use that and disable interactive tests if present?

Distributions can use it too.

stefansbv commented 13 years ago

It's not about interactive tests, it's about Makefile.PL, that is interactive and my proposal that makes it non interactive by default and preserves the old behavior.

stefansbv commented 13 years ago

Done it, merged the 'newsetup' branch, hope didn't mess-up anything! Updates for different platforms should be easier.

Darwin support not fully implemented.

Please, test it and open new issues if required.

mariuz commented 13 years ago

looks ok from the first look , the only issue is the test db is created with the user running the test (maybe we should add localhost when running with classic)