Tux
commented
10 years ago On Fri, 07 Feb 2014 09:09:17 -0800, Popa Marius Adrian notifications@github.com wrote:
Merged #38.
Should I make a new pull request for this one? https://github.com/Tux/perl-dbd-firebird/commit/56451a32df4a5997ffeb343aa896b5dffacba08d
Did you also see my RT Ticket #92810? That is a serious FAIL. And it prevents me from trying to support Firebird in modules like Tie::Hash::DBD - https://rt.cpan.org/Ticket/Display.html?id=92810
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.19 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
mariuz
• ibase.h is installed in /usr/include/firebird from the firebird-devel package, but that is not found, as /usr/include is a valid folder, so the alternatives are not checked • It is legal to have an empty password. The empty sting however evaluated to false in your tests • Allow FIREBIRD_DATABASE to set the database to test on, as File::Spec->tmpdir is not always allowed in firebird configuration • Test with predicatable float/double values, as those tests will otherwise fail on perl built with longdouble support • Test all attributes (I simplified the FETCH function a little bit, and I note that your XS code might not be thread-safe. I miss dTHX and aTHX in there). The test case now uses is_deeply and tests all supported attributes (I think)