search

mark-gerarts / automapper-plus

An AutoMapper for PHP
MIT License
551 stars 30 forks source link

Throw Exception instead "return;" #52

Open Slayer911 opened 4 years ago

Slayer911 commented 4 years ago

Please, change this comment to real exception https://github.com/mark-gerarts/automapper-plus/blob/d5ca462e99deae8c6628d15d5c67ab479ad1b8b9/src/MappingOperation/DefaultMappingOperation.php#L49 When this library is one block of big system, bugs like this is hard detection, if here will be real exception, life will be better, i think

mark-gerarts commented 4 years ago

Yes, you are right. However, throwing an exception here could be a backwards incompatible change. I will definitely incorporate this in the 2.0 release though. Thanks for reporting!

Slayer911 commented 4 years ago

Thank for great library)