mark-nicepants / figma2flutter

Converts design token json files to flutter
Apache License 2.0
17 stars 16 forks source link

Implement equality on DimensionValue #23

Closed freemansoft closed 3 months ago

freemansoft commented 4 months ago

DimensionValues are equal if their values are equal

Comparing doubles can be bad in some languages because of precision but precision errors results in less equality so I didnt' worry about it.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.48%. Comparing base (b20e952) to head (6af0604).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 98.46% 98.48% +0.01% ========================================== Files 31 31 Lines 847 856 +9 ========================================== + Hits 834 843 +9 Misses 13 13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frederikstonge commented 3 months ago

@freemansoft the owner of the repository doesn't seem really active. Should we start our own package?

mark-nicepants commented 3 months ago

I can add you as a member to this repo if you want :-) Dont have alot of time currently to pick it up

frederikstonge commented 3 months ago

I can add you as a member to this repo if you want :-) Dont have alot of time currently to pick it up

If you could add @freemansoft, he's the one who contributes the most!

mark-nicepants commented 3 months ago

Added both :-D

mark-nicepants commented 3 months ago

I can also add you guys to the pub.dev package later on. For now just ping me when you need a new version published and ill pull and run the script :-) All help is really appreciated 💯