mark-nicepants / figma2flutter

Converts design token json files to flutter
Apache License 2.0
17 stars 16 forks source link

[FEATURE REQUEST] Support filtering out token-sets (such as those "treated as source") #32

Open kvenn opened 2 weeks ago

kvenn commented 2 weeks ago

:speech_balloon: Description

If I mark a token-set as "source", it doesn't allow me to access those variables in Figma. Ideally it would work the same in the code.

If this is controversial, it would be great if there was a setting passed to the generator (or a config file) that allowed you to ignore certain token-sets. Or ignore source token-sets.

:question: Link to specification or documentation (if available)

Tokens studio docs

Details

themes/semantic-light references colors in core, but they shouldn't be accessible in the code (to prevent people from using colors directly instead of through the semantic theme token set).

In $themes.json there is this:

    "selectedTokenSets": {
      "global": "enabled",
      "core": "source",
      "theme/semantic-light": "enabled"
    },

image

kvenn commented 2 weeks ago

Style Dictionary has some generic approaches to how they handle it. Flutter impl.

https://v4.styledictionary.com/examples/splitting-output-files/ Looks like using "filters" is how they recommend doing it. https://v4.styledictionary.com/reference/hooks/formats/#filtering-tokens

freemansoft commented 2 weeks ago

The linked docs require a Figma login.

kvenn commented 1 week ago

Updated!

apackin commented 1 week ago

I opened a PR specific to omitting "core" tokens https://github.com/mark-nicepants/figma2flutter/pull/34. It could easily be modified to accept a list of paths for token sets to omit if that need arrises.