mark-wiemer-org / ahkpp

AutoHotkey Plus Plus (AHK++) - AutoHotkey v1 and v2 support for VS Code
https://marketplace.visualstudio.com/items?itemName=mark-wiemer.vscode-autohotkey-plus-plus
Other
152 stars 10 forks source link

Language Switch problems #415

Closed RaptorX closed 3 weeks ago

RaptorX commented 8 months ago

Type: Bug

Type: Bug Notes: Reported and closed here: #461

• have Autohotkey Plus Plus installed • have Autohotkey v2 Language Support Installed • Open a new file • Select ahk v1 language

Expected

Language switch should set V1

Result

V2 Gets selected

Notes

After v2 is selected I cant switch to v1 unless: 1) I set the requires directive 2) switch tabs and come back to the file

Manually switching to v1 is not working in any circumstance, seems like this extension is not responding to the switch event.

Code_KJOyB6hecc


Extension version: 5.0.3 VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:49:37.021Z) OS version: Windows_NT x64 10.0.22621 Modes:

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-4460 CPU @ 3.20GHz (4 x 3198)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|31.88GB (20.23GB free)| |Process Argv|S:\\Ultimate Spy --crash-reporter-id 3e042e59-cb22-4371-968a-6f3e35abe666| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 vserr242cf:30382550 vsjup518:30340749 vshan820:30294714 vscorecescf:30445987 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593cf:30376535 py29gd2263:30899288 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 azure-dev_surveyone:30548225 f6dab269:30613381 showlangstatbar:30737416 0bi6i642:30917235 fixshowwlkth:30771522 showindicator:30805244 pythongtdpath:30769146 i26e3531:30792625 welcomedialogc:30910334 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 dsvsc013:30795093 dsvsc014:30804076 dsvsc015:30845448 pythontestfixt:30902429 pyreplss1:30897532 pythonmypyd1:30879173 pythoncet0:30885854 2e7ec940:30885897 pythontbext0:30879054 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 aa_t_chat:30882232 cp7184c:30925681 ```
fade2gray commented 8 months ago

I saw you post in the other repo. It might not suit you, but this is the solution I use - it does rely on the use of the #Requires AutoHotkey v1+ directive, the use of separate folders and workspaces for v1/v2 scripts and the use of the Project Manager extension.

Edit : "Notes: Reported and closed here: #461" is a reference to the other repo.

Here's a hasty video.

https://github.com/mark-wiemer-org/ahkpp/assets/1332009/a2cd32e6-b57b-4897-a1ae-3edd29472338

mark-wiemer commented 8 months ago

Wow, thanks so much for the detailed workaround! I'll try to get to this bug shortly, but for now I think just adding "#Requires" to each file should help a lot--please let me know if you need further assistance, @RaptorX. Compatibility with other extensions will always be difficult, but I'll do my best to follow best practices :)

mark-wiemer commented 3 weeks ago

Closing as out of scope for now, I'm not able to reproduce this issue, and #Requires is strongly recommended by me. If #Requires solves the problem, I'll probably mark it as closed, unless there is a really significant issue.