Fixes compile errors during test and registers the ahk2 type

mark-wiemer-org / ahkpp

AutoHotkey Plus Plus (AHK++) - AutoHotkey v1 and v2 support for VS Code

https://marketplace.visualstudio.com/items?itemName=mark-wiemer.vscode-autohotkey-plus-plus

Other

152 stars 10 forks source link

Fixes compile errors during test and registers the ahk2 type #446

Closed Lootwig closed 3 months ago

Lootwig commented 3 months ago

Relates to #413. This and others are pointed to an issue recommending to change the file version, which is only a workaround for the underlying missing language type registration

Changes proposed in this pull request:

Register ahk2 during activation
Add dependency and update tsconfig, without which project tests wouldn't compile

Notifying @mark-wiemer

mark-wiemer commented 3 months ago

I appreciate the initiative, @Lootwig, but I think there's a misunderstanding. The providers in place were built only for v1. Registering these providers for v2 scripts will result in a lot of confusion, syntax errors, bad suggestions, and improper formatting that may even affect the execution order of the code. We can't register v2 providers until we have, well, providers written for v2. Happy to discuss more in a discussion or this closed PR if you like. Ref also #381 and #382

Lootwig commented 3 months ago

My bad, I naively considered the working syntax highlighting an indicator of "language is implemented" without realizing into how many subsystems language support is actually split.

I'm not sure how I managed to drop the commit with the config update, but I did a dum-dum there as well anyway, overlooking info that's available in contribute.md.