search

markabrahams / node-net-snmp

JavaScript implementation of the Simple Network Management Protocol (SNMP)
211 stars 97 forks source link

Example of using callback data. Note change to provided data in index.js #163

Closed derrell closed 3 years ago

derrell commented 3 years ago

There's a lot of fairly intricate code required to take advantage of this information in the varbinds. Are you really sure you want to put this onus on the user?

Note also that in the case of modifying a table column value, the column number that was given to the user was the "number" column, not the index into the array. The latter is what the user likely needs. I changed it so both are provided.

markabrahams commented 3 years ago

Merged and published in version 3.3.3 of the npm.

I've renamed "columnIndex" to "columnPosition" - just because it's something quite different from "rowIndex", and I thought it would be less confusing to re-use the "index" moniker for two quite different meanings in rows and columns.

derrell commented 3 years ago

I had the same thought, and couldn't think of anything better than columnIndex. columnPosition is far superior. Perfect.