Closed christopher-nielsen-ny closed 9 months ago
Hi @christopher-nielsen-ny - thanks for raising this and for the PR. I'll merge this shortly.
I've just merged #242 to fix this, and published in version 3.9.8 of the npm.
I've just merged #242 to fix this, and published in version 3.9.8 of the npm.
Great, thank you so much Mark!
The current implementation for
session.subtree()
doesn't appear to check the return value offeedCallback
, preventing user code from avoiding further calls. That's easily reproduced with a callback that returnstrue
. It's also immediately clear from thenode-net-snmp
code in question:The fix is trivial, and might look like the following (to be consistent with other
node-net-snmp
code):While very trivial, I'd be happy to submit a PR if it would help. Please let me know either way.