search

markafitzgerald1 / cribbage-analyst

Two-player cribbage discard analysis tool
https://markafitzgerald1.github.io/cribbage-analyst/
Mozilla Public License 2.0
0 stars 0 forks source link

Resolve Travis build failure on current (v9.10.1) and latest Active LTS (8.11.1) versions of Node.js #27

Closed markafitzgerald1 closed 6 years ago

markafitzgerald1 commented 6 years ago

From the 2018-04-02 Travis CI log at https://travis-ci.org/markafitzgerald1/cribbage-analyst/jobs/361464866:

[03:35:00] Starting 'jsdoc'... [03:35:00] 'jsdoc' errored after 206 ms [03:35:00] Error in plugin 'gulp-jsdoc' Oooooh! Failed rendering with jsdoc. What did you do?! Error: EISDIR: illegal operation on a directory, copyfile '/home/travis/build/markafitzgerald1/cribbage-analyst/node_modules/jsdoc/templates/default/static/scripts/linenumber.js' -> './jsDoc/scripts' The command "node_modules/gulp/bin/gulp.js clean default" exited with 1. Done. Your build exited with 1.

Looks to be some sort of incompatibility with the version of jsdoc the Gulp pipeline is using and the current Node current.

markafitzgerald1 commented 6 years ago

nvm installed as first step towards reproducing issue locally. Latest version of Node.js 4 LTS, 4.9.1, also locally installed via nvm to ensure am able to reproduce how Travis CI is running Node 4 builds of this project.

markafitzgerald1 commented 6 years ago

It will probably be helpful to test that Node.js 6 and 8 builds pass in order to pinpoint exactly which version jsdoc stopped working in. That should make #28 fairly easy to close.

markafitzgerald1 commented 6 years ago

Latest version of Node.js 6 LTS, 6.14.1, locally installed and verified to build cribbage-analyst succesfully and without warning once dependencies reinstalled - though install of dependencies has many deprecation warnings (filed as #30). Can leverage this piece of knowledge to add Node.js 6 to Travis CI targets as a part of resolution of #28.

markafitzgerald1 commented 6 years ago

Same issue exists in Node.js 8 LTS:

[03:48:18] Starting 'jsdoc'...
[03:48:18] 'jsdoc' errored after 210 ms
[03:48:18] Error in plugin 'gulp-jsdoc'
Oooooh! Failed rendering with jsdoc. What did you do?! Error: EISDIR: illegal operation on a directory, copyfile '/home/travis/build/markafitzgerald1/cribbage-analyst/node_modules/jsdoc/templates/default/static/scripts/linenumber.js' -> './jsDoc/scripts'
markafitzgerald1 commented 6 years ago

Issue does not exist in Node.js 6(.14.1) LTS.

markafitzgerald1 commented 6 years ago

Issue resolved in Node.js Active LTS 8 and Current (9) by replacement of deprecated and crashing gulp-jsdoc with gulp-jsdoc3 in 6c3809b as a part of work to update deprecated dependencies for #30.