search

markafitzgerald1 / cribbage-analyst

Two-player cribbage discard analysis tool
https://markafitzgerald1.github.io/cribbage-analyst/
Mozilla Public License 2.0
0 stars 0 forks source link

Make inputs and 6+ card analysis font sizes similar to desktop on mobile Chrome, Firefox, Safari and Edge #34

Closed markafitzgerald1 closed 6 years ago

markafitzgerald1 commented 6 years ago

6+ card analysis font 2.5 to 3 times larger than static text and input fonts on Chrome for Android on Samsung Galaxy S6 running latest version of Android for S6. Input font size always too small on mobile.

markafitzgerald1 commented 6 years ago

Consider switching back to Continuous Deployment model for this project on this issue - Git Flow has a lot of overhead (develop, feature and release-* branches + associated builds and merges), which isn't buying much value for this project - tests are thorough - broken code not often getting deployed to production if ever so far.

markafitzgerald1 commented 6 years ago

Reading https://stackoverflow.com/a/35564095, https://www.quirksmode.org/mobile/viewports2.html and https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag to learn how to handle this issue.

markafitzgerald1 commented 6 years ago

Based on reading the above <meta name="viewport" content="width=device-width, initial-scale=1"> or similar (see MDN for variations) should move this issue much closer to resolution.

markafitzgerald1 commented 6 years ago

Resolved in 15f4504 pending merge into develop.

markafitzgerald1 commented 6 years ago

Resolved on merge of https://github.com/markafitzgerald1/cribbage-analyst/pull/59 into develop.

markafitzgerald1 commented 6 years ago

Open until merged to master (via a release branch), built on master, deployed to productional and the release branch has been merged into develop and successfully built on develop.

markafitzgerald1 commented 6 years ago

Resolved in released version 0.2.2: https://github.com/markafitzgerald1/cribbage-analyst/releases/tag/0.2.2.