search

markafitzgerald1 / cribbage-trainer

Two-player cribbage discard and play improvement tool.
Mozilla Public License 2.0
1 stars 0 forks source link

🚀 ci(e2e): Always e2e test on Linux #37

Closed markafitzgerald1 closed 9 months ago

markafitzgerald1 commented 9 months ago

docker-e2e-test takes 32 seconds locally on a non-Linux development environment... + 3 seconds beforehand for rm -rf node_modules and 28 seconds for npm install afterwards to restore the local app install = 63 seconds vs. the 10 seconds it took to run plain npm run test-e2e before on macOS.

This large runtime can likely be significantly reduced by using a Dockerfile in order to cache the apt updated image with make, gcc and g++ installed.

markafitzgerald1 commented 9 months ago

apt update, apt install and npm install times all saved via Docker image layering and caching now. Overall docker-test-e2e runtime is now about 15 seconds when OS is up to date and Cribbage Trainer npm dependencies have not changed since the last build.