Sort order not changing on touch on mobile

markafitzgerald1 / cribbage-trainer

Two-player cribbage discard and play improvement tool.

Mozilla Public License 2.0

1 stars 0 forks source link

Sort order not changing on touch on mobile #70

Closed markafitzgerald1 closed 5 months ago

markafitzgerald1 commented 5 months ago

Looks like a recent regression in production.

markafitzgerald1 commented 5 months ago

Same problem exists on desktop. Only occurs in production builds - add a Storybook interaction test once SortableHand stories exist. (They're being implemented in #21.)

markafitzgerald1 commented 5 months ago

Fixed in 59ad2cdf85a5143bfb0ebb701eb57efef3f86c35 via move of act() from source code to test code, as it was only added to clean up a Jest test warning.

TODO:

[x] Add a Storybook interaction test to prevent this from re-occurring once SortableHand Stortbook stories exist (via #21 work).

markafitzgerald1 commented 5 months ago

Moved above TODO to #21 so that this Issue can be closed to simplify work tracking.

markafitzgerald1 commented 5 months ago

Fixed via https://github.com/markafitzgerald1/cribbage-trainer/pull/71.

markafitzgerald1 commented 4 months ago

Regression test for this added in https://github.com/markafitzgerald1/cribbage-trainer/pull/86.