markahesketh / Prestashop-Theme-Boilerplate

A boilerplate 'blank slate' theme for Prestashop
97 stars 28 forks source link

Reduce and streamline CSS #5

Open markahesketh opened 12 years ago

markahesketh commented 12 years ago
damonsk commented 11 years ago

I'm currently using this boilerplate as a base and creating a style upon it, I've noticed there is no defined CSS/Less for the shopping-cart html. If I was to create a base style/css structure, would it be suitable to place this within the global.less file. Since prestashop doesn't include a separate css file for the shopping-cart, this seems like the only logical location without users having to call addCSS.

Whats your view on this?

markahesketh commented 11 years ago

If there's no shopping-cart.css thats automatically included then it'd depend on what I was making.

If I was making a generic theme to sell etc I'd put it in global as you suggest, however if I was working on a client store where I had control over the overrides etc I'd use addCSS/setMedia to include the CSS on the shopping-cart only.

I'm going to be reevaluating the theme over the next couple of days, upgrading it to 1.5.2, and reconsidering using LESS etc and stripping everything back to become more of a boilerplate, and less of a Framework so all kinds of assumptions are removed.

Mark Hesketh 07874035593 http://www.markhesketh.co.uk

On Wednesday, 28 November 2012 at 09:43, Damon Skelhorn wrote:

I'm currently using this boilerplate as a base and creating a style upon it, I've noticed there is no defined CSS/Less for the shopping-cart html. If I was to create a base style/css structure, would it be suitable to place this within the global.less file. Since prestashop doesn't include a separate css file for the shopping-cart, this seems like the only logical location without users having to call addCSS.
Whats your view on this?

— Reply to this email directly or view it on GitHub (https://github.com/heskethm/Prestashop-Theme-Boilerplate/issues/5#issuecomment-10796236).