Thanks!

[Tketa]

Hello! Thank you for submitting the first homework for CoderSchool React Class 🎉! The main focus of this assignment was to introduce you to working with an API, rendering items in a collection, and dealing with state and props.

Great ✨

• Good job putting all the components in a separate Components folder. Structuring your application properly becomes increasingly important as it grows, and I feel like you got an hint about that. However coherence is important, and other folders are written in lowercase, so perhaps components would have been a better name.
• Great job completing all the features and coming up with a great interface. You went above and beyond !
• Binding the function to this inside the constructor is good practice, that's great.
• Good job fetching the data in App.js in componentDidMount. The official Facebook React Native example does this as well. (React and React Native have the same convention here.)

Not so great yet 🚩

• App.js is definitely too big. What I would have done:
  • Create a SortableMovieList component that handles all the sorting part. The MoviesList component does not have to know about the sorting, it is simply given some movies as props and its role is to display them. On the other hand doing all the sorting in App.js is too heavy. I tried to show you what I mean in the pull request I created
• Follow strict indentation so that it is clear by looking at your code which element in contained in another one.
• You should have passed the entire movie object as a props to the MovieCard component. This way you just had to write <MovieCard movie={movie} /> once, and then inside the MovieCard component you decide what to display.
• Don't create your styles in the render() function, they don't need to be there (they can be declared outside of the render(), even in a separate file even if I think it's better in the component). In general, avoid putting anything unnecessary in the render() function (anything not dependant on props or state can go outside)
• Don't leave comments in the code unless you want to say something useful :)

[Tketa]

See it here: https://github.com/maktubhelou/flixie-source-code/pull/2

[markallanevans]

Thank you for the comments. Very helpful. Definitely makes more sense to pass the entire movie object to MovieCard, not sure what I was doing there other than making life more difficult. The refactoring is definitely helpful. In fact I tried to do this and broke the App a few times, possibly just out of fatigue. In the end I left it as it was so that it would actually work as it was nearing the deadline. You example helps. I'm going to have a go at doing it without looking at your code and if I run into trouble, use it as reference.