search

markandrus / build-webrtc

14 stars 12 forks source link

Add a `clean` rule #1

Closed getkey closed 7 years ago

getkey commented 7 years ago

It is useful to run this when updating webrtc because creating libwebrtc.a is done by merging *.o files. When updating from v50 to v51 for example, some of those files are no longer produced, but if old .o files are laying around they will get merged with the new ones, which will cause linking errors.

markandrus commented 7 years ago

This sounds like a good idea, thank you. I am traveling right now but hope to review later this week.

On Sun, Dec 18, 2016 at 10:36 PM Julien Mourer notifications@github.com wrote:

It is useful to run this when updating webrtc because creating libwebrtc.a is done by merging *.o files. When updating from v50 to v51 for example, some of those files are no longer produced, but if old .o files are laying around they will get merged with the new ones, which will cause linking errors.

You can view, comment on, or merge this pull request online at:

https://github.com/markandrus/build-webrtc/pull/1

Commit Summary

  • Add a clean rule

File Changes

-

A

jakelib/clean.jake https://github.com/markandrus/build-webrtc/pull/1/files#diff-0

(10)

-

M

package.json https://github.com/markandrus/build-webrtc/pull/1/files#diff-1

(1)

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/markandrus/build-webrtc/pull/1, or mute the thread https://github.com/notifications/unsubscribe-auth/AAV68i0j6hhHpbRhMrBV0IkRc2EFl9fPks5rJVLjgaJpZM4LQJ-P .

markandrus commented 7 years ago

@getkey looks good! Thank you.