markasoftware / SpecDB

A beautiful web app for viewing and comparing the specifications of PC hardware.
https://specdb.info/
GNU Affero General Public License v3.0
29 stars 11 forks source link

Update to database contents. #17

Closed zcskywire2 closed 7 years ago

zcskywire2 commented 7 years ago

This update would add support to the database for Ryzen 3, Threadripper and Epyc product lines. Sorry for the large numbers of commits, was learning to use GitHub (also was using the to save files while i was at work on mobile...)

markasoftware commented 7 years ago

Great, overall looks pretty good. It's a bit late here so I'll probably be able to review and merge this tomorrow.

markasoftware commented 7 years ago

Okay, I've found a few problems so far which are worth mentioning:

I really appreciate what you've done by adding these parts, and if you don't get to fixing these I'll be happy to do it myself, it just might take a bit longer.

zcskywire2 commented 7 years ago

I can certainly go through the yaml files and tighten up those minor issues. Most of the extra lines are there as I just reverse engieered how they function. As for why I layed out the processors as I did, many people do not know the names of the mirco-archs. Most people will know the product linup that the processors are a member of. This is mainly how the ark.intel site is layed out. Futhermore it reduces the clutter on the later pages. With all the zen based CPUs on one page you end up with over 22 processor sku's. Some mirco-archs will have even more such as bulldozer. Having it done this way will speed up the search for a particular sku and will make it easier to find a ski for a non technical person. And even though the arch family is no longer listed the mirco arch is.

zcskywire2 commented 7 years ago

I've gone through all the yaml files that I created and checked them for the items listed above fixing all the above. I've also continued adding processor families by adding the AMD FX Bulldozer CPUs.

markasoftware commented 7 years ago

Okay, looks good. I'll probably make a few final changes to the layout of everything before merging this (hopefully later today), and I'll need to make a small change in the main codebase to have it support "TBA" values properly. Thanks!

zcskywire2 commented 7 years ago

While I'm thinking about it, what does the database support in the way of dates. Mainly because some of the CPUs added haven't had a release date announced. Others that could be added only have their relase date as a quarter. Ex q4 2016. I don't know how you would want those ones filled in for the date. Also started adding support for the entire Phenom II processor linup, so if you have any thoughts how you want them later out let me know. Currently it's broken down on the main screen into X6 header and then it's familes, x4 header then is familes , x3 ..., X2... Either way I'mma just keep moving forward and adding more to the database

markasoftware commented 7 years ago

Currently dates only allow strings in yyyy-mm-dd format. Adding support for quarters is a good idea. I've opened an issue for this to keep track of it and remind myself.

markasoftware commented 7 years ago

Changes are live!

zcskywire2 commented 7 years ago

I've now got the full set of Phenom II updates completed. Just trying to fix the conflict between the branches and then you'll be getting another pull request.