search

markasoftware / SpecDB

A beautiful web app for viewing and comparing the specifications of PC hardware.
https://specdb.info/
GNU Affero General Public License v3.0
29 stars 11 forks source link

CPU human names cannot consist only of numeric characters #22

Closed zcskywire2 closed 7 years ago

zcskywire2 commented 7 years ago

When a CPU human name consists only of numeric characters and spaces the application fails to load properly. The background and tabs will be drawn but none of the database's contents will be displayed. This will not cause any issue when compiling only in the display.

markasoftware commented 7 years ago

Generally speaking, I don't think any parts should consist of only numeric characters, but this is still a bug and will be fixed soon.

markasoftware commented 7 years ago

Actually, I am going to close this issue without fixing it, because it only really makes sense for a name to be a string -- a numerical name doesn't make much sense, since doing arithmetic operations on a name is meaningless. You can force YAML to treat a number as a string by enclosing it with quotes (e.g, humanName: '123'), which is how a name which is a number should be dealt with.