markasoftware / SpecDB

A beautiful web app for viewing and comparing the specifications of PC hardware.
https://specdb.info/
GNU Affero General Public License v3.0
29 stars 11 forks source link

Changing ryzen from 'r' to 'ryzen' #81

Closed Sam-Mear closed 1 year ago

Sam-Mear commented 1 year ago

Keeping ryzen naming scheme consistent

Sam-Mear commented 1 year ago

I did a quick change to succesfully get some benchmark results(last commit). But due to the name change this test now fails

test('3PM: Ryzen', t => {
    t.equal(threepm({
        name: 'Ryzen 7 1800X',
    }), 'R7-1800X');
    t.equal(threepm({
        brand: 'amd',
        type: 'cpu',
        name: 'Ryzen 5 1600',
    }), 'R5-1600');

    t.end();
});

in third-party-matchers.js line 16

markasoftware commented 1 year ago

great! And thanks for fixing the geekbench scraper at the same time.