markbates / goth

Package goth provides a simple, clean, and idiomatic way to write authentication packages for Go web applications.
https://blog.gobuffalo.io/goth-needs-a-new-maintainer-626cd47ca37b
MIT License
5.2k stars 566 forks source link

Minor improvements in the providers map in examples #500

Closed antichris closed 1 year ago

antichris commented 1 year ago
  1. Initialize provider title map instead adding values one by one.

    It's much more readable this way.

    And, technically, more resource efficient (on my system, ~-59% sec/op, ~-51% B/op, -2/3 allocs/op). Although — who cares — this only runs once and in an example.

  2. Spell Battle.net the way they do.

  3. Spell LinkedIn the way they do and prefer done.

techknowlogick commented 1 year ago

Thanks so much for this PR 😃 I'm going to remove the hidden file, but will merge this PR shortly.

edit: nvm, I saw what the hidden file did, and will merge this as-is :)