search

markbates / pkger

Embed static files in Go binaries (replacement for gobuffalo/packr)
MIT License
1.19k stars 60 forks source link

Remove Hamlet? #66

Open chris-branch opened 4 years ago

chris-branch commented 4 years ago

I noticed my compiled executables that use pkger have the entire script of Hamlet embedded in the binary, which adds an additional ~180K to the file size. It seems to be coming from here:

https://github.com/markbates/pkger/blob/master/internal/takeon/github.com/markbates/hepa/filters/masks.go#L40

I have nothing against Shakespeare, but is there a different way to generate masked values that doesn't add an extra 180K to every executable that includes this package? Or perhaps, a way to exclude this code at build time if masking is not needed?

bojanz commented 4 years ago

This will be fixed by https://github.com/markbates/pkger/pull/102 it seems

requaos commented 4 years ago

@chris-branch since #102 has been merged, this can be closed.