search

markbates / refresh

MIT License
191 stars 30 forks source link

Reverted commit 90f2daf #18

Closed nullbio closed 7 years ago

nullbio commented 7 years ago

Hi Mark, is there a reason 90f2daf was reverted? Thanks.

nullbio commented 7 years ago

Revert here: https://github.com/markbates/refresh/commit/25435da78dbf2fa5067f3c156051103ad72bce0e

markbates commented 7 years ago

Yes; it was causing significant CPU usage. Reverting this commit brought CPU usage from 100+% to 0.3% on my machine. A lot of users complained about the increased CPU usage.

nullbio commented 7 years ago

You've reverted two commits, the one I'm referring to above seems unrelated to CPU usage. The CPU usage commit you reverted is here: https://github.com/markbates/refresh/commit/0b2bb8035576fb5fffcee9eed3233be1abdc9098

markbates commented 7 years ago

That commit needed to be reverted twice due do a bad merge.

Mark Bates

On Jul 12, 2017, 9:58 PM -0600, nullbio notifications@github.com, wrote:

You've reverted two commits, the one I'm referring to above seems unrelated to CPU usage. The CPU usage commit you reverted is here: 0b2bb80 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

nullbio commented 7 years ago

This is somewhat confusing, because you've removed two different features and one is unrelated to CPU usage. Even if it needed to be reverted twice you definitely reverted two separate pieces of code.

Just to clarify again, this is the commit I'm referring to which was merged a while ago: https://github.com/markbates/refresh/commit/90f2daf12da08f62255f309ece774fa94604a20f which has now seemingly mistakenly been reverted since it has nothing to do with CPU usage.

The one that seems intentionally reverted is here: https://github.com/markbates/refresh/commit/0b2bb8035576fb5fffcee9eed3233be1abdc9098 which has a commit message that refers to huge CPU usage.

nullbio commented 7 years ago

Hey @markbates not sure if you saw my reply. Just trying to get this sorted as quick as possible.

markbates commented 7 years ago

I have. I'm at GopherCon and have been very busy. Sorry. I will try and sort this out tomorrow.

markbates commented 7 years ago

@nullbio ok, it's back in there. sorry about that.

nullbio commented 7 years ago

@markbates Thank you Mark.