search

markbates / refresh

MIT License
191 stars 30 forks source link

Skip -i flag in go build if modules are enabled #25

Closed cippaciong closed 6 years ago

cippaciong commented 6 years ago

Using -i flag when running go build is not useful with go modules enabled and in some cases can lead to a bug, with go trying to rebuild shipped vendorized dependencies as described in this issue https://github.com/golang/go/issues/27285. With this commit we check if go modules are enabled and we drop the -i flag accordingly.

cippaciong commented 6 years ago

I made the changes you requested, hope I did them right

markbates commented 6 years ago

Awesome! Thanks. I’ll cut a release next time I’m near a computer.

cippaciong commented 6 years ago

Should I apply the same changes to https://github.com/gobuffalo/buffalo/blob/master/buffalo/cmd/build/bin.go#L35 ?

markbates commented 6 years ago

Only if it’s in the development branch, that’s where all Buffalo development happens.

Thanks.

Mark Bates On Sep 29, 2018, 11:53 AM -0400, Tommaso Sardelli notifications@github.com, wrote:

Should I apply the same changes to https://github.com/gobuffalo/buffalo/blob/master/buffalo/cmd/build/bin.go#L35 ? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

cippaciong commented 6 years ago

Yeah, sure. Thank you for all your help :+1:

markbates commented 6 years ago

Thank you for finding/fixing the issue! :)

Thanks.

Mark Bates On Sep 29, 2018, 11:55 AM -0400, Tommaso Sardelli notifications@github.com, wrote:

Yeah, sure. Thank you for all your help 👍 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.