Watcher Filenotify interface (Polling & fsnotify)

markbates / refresh

MIT License

191 stars 30 forks source link

Watcher Filenotify interface (Polling & fsnotify) #32

Closed syntaqx closed 5 years ago

syntaqx commented 5 years ago

Pulls in github.com/docker/docker/pkg/filenotify as a managed dep (Apache License, Version 2.0)
- There's a conflict with [Ss]irupsen/logrus naming in the dependency chain
- Docker committed their vendor folder for the CLI, so importing the real package prior to Go 1.11 isn't worth the effort.
Removes pkg from .gitignore for the filenotify package. This is a common pattern, we should keep it.
Adds a force_polling optional configuration to enable the poller.
Accepts the interface where needed rather than fsnotify's struct

Closes #31

While this does introduce a new dependency, this can be included as a minor version release as it does not introduce any backwards incompatible functionality.

syntaqx commented 5 years ago

~~Hold on merging this as so I can review it a bit more indepth tomorrow, I'm having some flaky reliability with the binary right now.. It could be my system, but I want to test a few more things.~~

This was my bad, I broke my .refresh.yml file with a new format I was playing with and forgot to reset it. This is good to go!

syntaqx commented 5 years ago

@markbates Let me know if you need anything else from me on this, but we're good to merge as far as I'm concerned.

markbates commented 5 years ago

I haven’t had the time to even look at this, sorry. I will try over the next few days.

Mark Bates On Feb 14, 2019, 2:34 PM -0500, Chase Hutchins notifications@github.com, wrote:

@markbates Let me know if you need anything else from me on this, but we're good to merge as far as I'm concerned. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

syntaqx commented 5 years ago

Is the pkg convention not something you want to utilize? Personally I'm a big fan of the formality, but if you're not I suppose I can pull it back out.

markbates commented 5 years ago

Please remove it. Thanks.

Mark Bates On Feb 15, 2019, 3:16 PM -0500, Chase Pierce notifications@github.com, wrote:

Is the pkg convention not something you want to utilize? Personally I'm a big fan of the formality, but if you're not I suppose I can pull it back out. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

markbates commented 5 years ago

Looks good. I want to run this on some more platforms before I merge.