search

markbergsma / pimatic-hue-zll

Pimatic integration with Philips Hue (ZLL)
GNU General Public License v2.0
7 stars 4 forks source link

Restoring last state #15

Closed michbeck100 closed 1 year ago

michbeck100 commented 7 years ago

This PR restores the last state of some of the device classes. This hopefully fixes https://github.com/michbeck100/pimatic-hap/issues/43

michbeck100 commented 7 years ago

@markbergsma Will this PR be merged?

markbergsma commented 7 years ago

Could you explain a bit better what you're trying to accomplish?

I didn't implement 'lastState' as in principle the Hue ZLL plugin is able to retrieve the current status of the system from the Hue API (although that isn't instant).

It looks like you're trying to break some infinite loop between pimatic-hap and pimatic-hue-zll. I don't use pimatic-hap myself so I can't easily test this. Why does this PR make a difference?

Thanks!

michbeck100 commented 7 years ago

It doesn't make a difference anymore actually. The bug on pimatic-hap side is solved. It wasn't because of pimatic-hue-zll. Nevertheless this PR creates the same consistent behavior that all built-in devices have when getting created, they restore their last state from the pimatic database. It's up to you to merge this PR.