markcell / jquery-tabledit

Inline editor for HTML tables compatible with Bootstrap.
http://markcell.github.io/jquery-tabledit/
MIT License
435 stars 208 forks source link

hideIdentifier not working for me (Tabledit v1.2.3) #144

Open ian-brackenbury opened 4 years ago

ian-brackenbury commented 4 years ago

hideIdentifier=true doesn't hide the identoifoer column. However the fix is easy.

// Hide identifier column. About line 92in $table.find the "ParseInt(..) + 1" is being treated as concatenation not addition. Just wrap that in parens, as is done for the almost identical expressions following it.

iShubhamRaj commented 3 years ago

hideIdentifier=true doesn't hide the identoifoer column. However the fix is easy.

// Hide identifier column. About line 92in $table.find the "ParseInt(..) + 1" is being treated as concatenation not addition. Just wrap that in parens, as is done for the almost identical expressions following it.

Thanks for the solution! I created pull request with the fix for this in this repo. Not sure if the maintainer will merge it though. Seems to be inactive!