search

markcox / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

make snappy compilation using msvc #64

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
snappy_test.h line 47 sys/time.h is not present in MSVC, so it should be 
protected by macro and configure scripts should be updated correspondingly.

#ifdef HAVE_SYS_TIME_H
#include <sys/time.h>
#endif

there are some compilation complains under msvc under win32/64 build, I'd 
examine them and see if there should be some patch to suppress them.

Original issue reported on code.google.com by hume...@gmail.com on 26 Jul 2012 at 12:33

GoogleCodeExporter commented 9 years ago 
Hi,

The missing include guard is fixed in r66. As of warnings, it's nigh-impossible 
to keep a project warning free on a compiler you don't even have; thus I doubt 
we're going to make an effort ourselves to fix MSVC warnings, but feel free to 
send patches as long as they don't uglify the rest of the code.

Original comment by se...@google.com on 31 Jul 2012 at 11:46

GoogleCodeExporter commented 9 years ago 
Hi sesse:
  Yes, I agree with you that compiler warning free is not necessary, there are some warnings under win64 build because size_t is 64bit and long is 32bit under win64, some cast trunctions may cause problems though, maybe these need some instigation, snappy is excel at speed and compression ratio, thanks for your effort.

Original comment by hume...@gmail.com on 31 Jul 2012 at 1:01