search

markcox / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

Mistakes on the start page #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In port list:
> C89 port

Projects do not use C89, at a minimum C99.

Original issue reported on code.google.com by bratsi...@gmail.com on 14 Jun 2013 at 10:23

GoogleCodeExporter commented 9 years ago 
Can you be a bit more specific? Which projects do you mean when you say 
“projects”?

Original comment by se...@google.com on 14 Jun 2013 at 10:28

GoogleCodeExporter commented 9 years ago 
Excuse me for my mistake. Not "projects", just a "project".

On the home page: http://code.google.com/p/snappy/
In the port list contains the link: http://github.com/andikleen/snappy-c
But the project is not on the C89. It on C99.

Original comment by bratsi...@gmail.com on 14 Jun 2013 at 11:56

GoogleCodeExporter commented 9 years ago 
Well, could you explain what C99 features it uses? Offhand I could only find 
the “inline” keyword, which is a common compiler extension, also in C89 
mode. (Witness that it compiles just fine with GCC, which defaults to C89 + 
extensions mode.) Then again, it also uses GCC's “asm” syntax, so it's not 
entirely portable anyway.

Original comment by se...@google.com on 14 Jun 2013 at 12:02

GoogleCodeExporter commented 9 years ago 
Variables are declared not at the beginning of the block.

Original comment by bratsi...@gmail.com on 14 Jun 2013 at 1:21

GoogleCodeExporter commented 9 years ago 
OK, fair enough, I found a few cases like this. I'll change it to just “C 
port”, as it isn't really C99 either (it depends on GCC extensions).

Original comment by se...@google.com on 14 Jun 2013 at 1:24