search

markdown-it / linkify-it

Links recognition library with full unicode support
http://markdown-it.github.io/linkify-it/
MIT License
655 stars 63 forks source link

url not matched when it contains `...:` #100

Open Bilb opened 2 years ago

Bilb commented 2 years ago

Hey,

First, thanks for the amazing library! This is linked to #66 I assume but I cannot make this URL be matched by linkify https://odysee.com/@spacebusters:c9/It's-beginning-to-look...:1 But without the semicolon it works: https://odysee.com/@spacebusters:c9/It's-beginning-to-look...1

and with the semicolon and not the triple dots, it works too https://odysee.com/@spacebusters:c9/It's-beginning-to-look:1

Any luck you can add ...: to the allowed match?

Thanks a lot

puzrin commented 2 years ago

Any luck you can add ...: to the allowed match?

Need more strict rule because phrase like link...: foo bar will cause false positive. Please provide more samples.

I do not reject, but any change starts with info collection to investigate patterns more deep. In euristic algorythms any "special case" should be as narrow as possible.

KeeJef commented 1 year ago

Need more strict rule because phrase like link...: foo bar will cause false positive. Please provide more samples.

  • It's important to understand, what can follow after : in your case. Multiple real samples required.
  • Your existing sample does not work (makes redirect). I'd prefer real link.

I do not reject, but any change starts with info collection to investigate patterns more deep. In euristic algorythms any "special case" should be as narrow as possible.

Seems the examples i can find are all Odysee links, some examples here

(Here the video title is "It's-beginning-to-look..." and Odysee encodes this title into their URL) https://odysee.com/@spacebusters:c9/It's-beginning-to-look...:1

Heres a few more Odysee links which are correctly detected

https://odysee.com/@AlphaNerd:8/i-built-an-online-store:1 https://odysee.com/@AlphaNerd:8/elon-musk's-twitter-rebrand-is:c https://odysee.com/@AlphaNerd:8/a-p2p-chicken-feed-and-compost-system:3

Seems that Odysee will put a letter or number after the colon, not sure what significance this has

edisondotme commented 1 month ago

Came to file this bug report. Interesting that everyone gets here because of Odysee links, which is the same for me. https://odysee.com/@SydneyWatson:a/the-parody-of-motherhood-continues...:4 gets shortened to: https://odysee.com/@SydneyWatson:a/the-parody-of-motherhood-continues on desktop for me.