search

markdown-it / linkify-it

Links recognition library with full unicode support
http://markdown-it.github.io/linkify-it/
MIT License
655 stars 63 forks source link

Add .app TLD to tlds_default #103

Closed buu700 closed 2 years ago

buu700 commented 2 years ago

The comment says not to submit a PR, so I won't do that, but .app is a pretty common/standard TLD nowadays and so seems to make sense in the default list.

puzrin commented 2 years ago

I see no reason for breaking changes, while you can configure TLD list as you wish.

ursnj commented 2 years ago

Yeah this is very much needed in recent days.

buu700 commented 2 years ago

Just to clarify, I do have .app configured in my own application; I'm just suggesting that it would make more sense to have as a default.

puzrin commented 2 years ago

Any change of defaults is breaking. We avoid breaking changes when other alternatives available. Let's keep things as is. Sorry for inconvenience.

buu700 commented 2 years ago

Got it, in that case it may just be something to consider for version 5.0.0.

puzrin commented 2 years ago

v5 may happen next day after "never" :). At current moment i have no ideas for v5.