search

markdown-it / linkify-it

Links recognition library with full unicode support
http://markdown-it.github.io/linkify-it/
MIT License
655 stars 63 forks source link

Url not detected correctly #79

Closed BusinessDuck closed 4 years ago

BusinessDuck commented 4 years ago

Example url : https://tc.myproj.com/httpAuth/app/rest/changes?locator=build:(running:any,sinceBuild:(buildType:My_BUILD_TYPE,status:SUCCESS))&fields=change(comment)

Matched result:

https://tc.myproj.com/httpAuth/app/rest/changes?locator=build:(running:any,sinceBuild:(buildType:My_BUILD_TYPE,status:SUCCESS))

Missing part: &fields=change(comment)

puzrin commented 4 years ago

Seems dupe of #23. Current implementation does not allow easy handle of nested patterns. Also, we can not blind allow multiple ))) due false positives for such case:

(text https://tc.myproj.com/httpAuth/app/rest/changes?locator=build:(running:any,sinceBuild:(buildType:My_BUILD_TYPE,status:SUCCESS)))

There are no way to detect where to stop without true nested parser.

I've added reference to #23 and closing this as dupe.