search

markdown-it / markdown-it-emoji

Emoji syntax plugin for markdown-it markdown parser
https://markdown-it.github.io/
MIT License
719 stars 167 forks source link

Support transforming of unicode emoji's to image based emoji's #10

Closed 3rd-Eden closed 8 years ago

3rd-Eden commented 8 years ago

Currently it's possible to add "native" unicode emoji's to documents which are differently styled then the :name: based emoji's which can lead to a really confusing experience.

puzrin commented 8 years ago

https://github.com/markdown-it/markdown-it-emoji#change-output

Isn't it described in readme?

3rd-Eden commented 8 years ago

I'm arguing that it should be supported by this library natively instead of resorting to writing your own implementations.

puzrin commented 8 years ago

I don't like this idea, because there can be different ways of extending. For example, with iconic fonts. It's not good to force user with twitter icons and make plugin dependent on external resources.

3rd-Eden commented 8 years ago

Also, in the example you are given, the md.renderer.rules.emoji function isn't even called when passing it an unicode emoji as the plugin only triggers on :...: chars, not unicode. But I guess i'll go write my own plugin then.

puzrin commented 8 years ago

I think, if you need to replace direct unicode chars, that's a bit another deal, not for this plugin. This plugin was done to work with markup.