Update command requires IP to function

markdumay / synology-pihole

Install or Update Pi-Hole as Docker Container on a Synology NAS with a Static IP Address

MIT License

55 stars 10 forks source link

Update command requires IP to function #18

Closed hoodncsu closed 2 years ago

hoodncsu commented 2 years ago

Existing instructions for scheduled update will timeout /bin/sh /path/to/your/script/syno_pihole.sh update -l /var/log/syno_pihole.log
They should specify /bin/sh /path/to/your/script/syno_pihole.sh update --ip 192.168.0.250 -l /var/log/syno_pihole.log
Additionally, the script should exit if --ip is not specified.

markdumay commented 2 years ago

Hi @hoodncsu, thanks for your feedback. What version of the script are you using? I fixed an issue with the update command in v1.2. Previously it did not initialize the variables correctly. It should now also warn about the missing IP address.

I'll add the --ip flag to the example in the README, similar to the network script. You could also use an .env file instead.

hoodncsu commented 2 years ago

My apologies, I pulled the repo a few hours before v1.2 was committed. I'll double check, but I am sure you are right. Thanks for putting this together, I ran across it in comments on http://tonylawrence.com/posts/unix/synology/free-your-synology-ports/, certainly saved me some frustration.

hoodncsu commented 2 years ago

Confirmed fixed in v1.2

markdumay commented 2 years ago

Ok, good to hear the issue has been fixed for you!

On 21 Sep 2021, at 15:14, hoodncsu @.***> wrote:

Closed #18.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.