search

markdumay / synology-pihole

Install or Update Pi-Hole as Docker Container on a Synology NAS with a Static IP Address
MIT License
58 stars 10 forks source link

Incorrect version #25

Closed markdumay closed 2 years ago

markdumay commented 2 years ago

The update script displays the incorrect version for the latest available package. Tested on DSM 7.1.

Install or Update Pi-hole as Docker container on Synology

Step 1 from 4: Validating DSM, Docker, and Docker Compose versions on host
Current DSM:               7.1
Current Docker:            20.10.3
Current Docker Compose:    1.28.5
Step 2 from 4: Detecting current and available Pi-hole versions
Current Pi-hole:           Unavailable
Target Pi-hole version:    76184753
76184753
76184753
2022.09.1
76184753
1998970
1998970
2022.09.1
2022.09.1
2022-09-02
20:37:10
2022-09-02
21:30:40
2022.09.1
2022.09.1
0d5a001916335
4b27408217063
9e04
7e0
2022.09
2022.09.1
5.14.1
2323
2324
76184753
Step 3 from 4: Creating Pi-hole container
Step 4 from 4: Testing Pi-hole availability
Testing...  Successfully connected to Pi-hole portal (http://192.168.1.250/admin/)
Done.
markdumay commented 2 years ago

The bug is no longer present in release 2022.09.4. However, the currently running version is not detected correctly. The ENV variable should be PIHOLE_DOCKER_TAG instead of PIHOLE_TAG.