search

markdwags / Razor

Razor is a free tool designed to help with simple tasks while playing Ultima Online.
https://www.razorce.com
GNU General Public License v3.0
139 stars 97 forks source link

Script editor autocomplete tooltip fix for mono #180

Closed dallenwilson closed 2 years ago

dallenwilson commented 3 years ago

This commit resolves the problem reported in issue #133, and without affecting tooltip behaviour on windows, that I can tell. Tested on Gentoo Linux w/ Mono 6.12.0.122 and Windows 10 w/.. whatever windows 10 ships with. No more crashes, and tooltips work in the script editor.

While the project maintainer in me is both in awe and a little jealous of anyone who actually plays the BOFH no-service-therefore-no-denial card and gets away with it, the problem irritated me enough to dig in to it and find another solution.

Give this a test and see if it works on your end.

markdwags commented 2 years ago

Thanks for tracking it down and fixing it. Looks good here, seems to behave as it did before on Windows, like you stated.

dallenwilson commented 2 years ago

I had this issue show up again this morning, and then vanish when I started testing to find the cause. Perhaps some sort of race condition when running under mono - something is occasionally null when the tooltip tries to generate, I'm just not sure what. I'll see if I can narrow it down, and I'll submit a new PR if I figure it out.