markdwags / Razor

Razor is a free tool designed to help with simple tasks while playing Ultima Online.
https://www.razorce.com
GNU General Public License v3.0
134 stars 90 forks source link

Extended text filter functionality to allow precise filtering of speech, Razor overhead messages and sys messages #191

Open Tranq1 opened 2 years ago

Tranq1 commented 2 years ago

Right now the text filter option under Filters -> Text & Messages only filters speech.

With this PR, players would be able to decide where the text should be filtered on:

For system messages, they can additionally decide if the filtered messages should still trigger overhead messages and be found via the "insysmsg" script expression.

The change is backwards compatible so players using the speech filter already won't notice any changes.

image

Tranq1 commented 2 years ago

I'm finished with the implementation now. Debugged and tested it as much as I could on Outlands and had no more issues.

It also fixed a previous bug where overhead messages would not be registered if the sys message was filtered by the "filter repeated system messages" option.

The new edit form for filter options is still a bit choppy, it looks good in the designer but not when I run it. But that's just aesthetics.