markedjs / marked

A markdown parser and compiler. Built for speed.
https://marked.js.org
Other
33.23k stars 3.39k forks source link

fix: update punctuation regex syntax for compatibility #3540

Closed BlueCat0 closed 1 day ago

BlueCat0 commented 2 days ago

Marked version: 13.0.1

Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

Description

Expectation

Marked should work fine in most cases.

Result

Host environment reports error due to unsupported regex syntax.

What was attempted

-->

Contributor

Committer

In most cases, this should be a different person than the contributor.

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 1:11pm
UziTech commented 1 day ago

We don't have any browser tests. I think if we are going to list specific browsers we should have some tests to make sure we are compatible.

We support node >= 18 so really we support any browsers that have the same APIs as node 18

0xDing commented 1 day ago

我们没有进行任何浏览器测试。我认为如果我们要列出特定的浏览器,我们应该进行一些测试以确保兼容性。

我们支持 node >= 18,因此我们实际上支持任何具有与 node 18 相同 API 的浏览器

Incompatible with React Native (Hermes Engine)

UziTech commented 1 day ago

It should work with the latest version https://github.com/facebook/hermes/pull/1295