markembling / MarkEmbling.PostcodesIO

.NET library for interacting with the excellent Postcodes.io service.
MIT License
23 stars 16 forks source link

Ced #20

Closed KarstenGrauRasmussen closed 11 hours ago

KarstenGrauRasmussen commented 5 years ago

Why is "ced" not available in PostcodeResult?

When we lookup ex. OX14 3PF we would like to use. "Abingdon East". When we use Postcodes.io website this is returned in ced, but the property is not included in PostcodeResult.

markembling commented 5 years ago

It's not available because it's newer than the current version of the library (i.e. the API didn't used to have it).

I'm working on a new version which adds this (commit 72be9b7731d3a15ad144ac85fa22a7d56ec9bf74), along with a whole load of other new API additions, a major overhaul of how it all works, and much better tests.

You're welcome to wait for the next release, although I can't guarantee when that will be as I work on this in my (very limited) free time. Alternatively, if you can't wait and don't mind building your own version from source, take a look at the vnext-wip branch. It should build and be usable, it's just not got the test coverage I wanted before releasing.

KarstenGrauRasmussen commented 5 years ago

Hi Mark

Thanks for your prompt reply. Sounds good, looking forward for the next release.

/Karsten

Den ons. 26. jun. 2019 kl. 11.35 skrev Mark Embling < notifications@github.com>:

It's not available because it's newer than the current version of the library (i.e. the API didn't used to have it).

I'm working on a new version which adds this (commit 72be9b7 https://github.com/markembling/MarkEmbling.PostcodesIO/commit/72be9b7731d3a15ad144ac85fa22a7d56ec9bf74), along with a whole load of other new API additions, a major overhaul of how it all works, and much better tests.

You're welcome to wait for the next release ,although I can't guarantee when that will be as I work on this in my (very limited) free time. Alternatively, if you can't wait and don't mind building your own version from source, take a look at the vnext-wip branch. It should build and be usable, it's just not got the test coverage I wanted before releasing.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/markembling/MarkEmbling.PostcodesIO/issues/20?email_source=notifications&email_token=AKHI3YDXTYQMB6SZHEXSV73P4MZ5DA5CNFSM4H3QHCDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYS6GCI#issuecomment-505799433, or mute the thread https://github.com/notifications/unsubscribe-auth/AKHI3YHSZNWFSV52SR4CVNLP4MZ5DANCNFSM4H3QHCDA .

--

Med venlig hilsen | Best Regards

Karsten Grau RasmussenDeveloper, Co-owner

Speedware ApS Nørrekobbel 7B https://maps.google.com/?q=N%C3%B8rrekobbel+7B%C2%A0%7C%C2%A0DK-6400+S%C3%B8nderborg&entry=gmail&source=g

https://maps.google.com/?q=N%C3%B8rrekobbel+7B%C2%A0%7C%C2%A0DK-6400+S%C3%B8nderborg&entry=gmail&source=gDK-6400 Sønderborg https://maps.google.com/?q=N%C3%B8rrekobbel+7B%C2%A0%7C%C2%A0DK-6400+S%C3%B8nderborg&entry=gmail&source=g | CVR: 34590176

Tlf: (+45) 42 44 45 44 Tlf: (+47) 23 96 66 15 Tlf: (+46) 31 30 88 377 Tel: (+44) 20 80 687 615

Email: info@speedadmin.com Web: www.speedadmin.com http://www.speedadmin.com/

markembling commented 11 hours ago

Sorry to say that for various reasons, I never found time to finish the rewrite I wanted and in the meantime, the library has got more and more out of date, including this missing CED field.

I'm now hoping to dedicate some time to the work I wanted to do back in 2019 and finish the overhaul to modernise things and improve the API, then release a v1.0.0.

In the meantime though, I've made a few minor updates to the library (including adding the CED field) and have released v0.0.12 which resolves this issue. That is available on Nuget now.