search

marker-io / browser-sdk

Marker.io browser SDK
MIT License
8 stars 8 forks source link

Feature: Typescript declarations #14

Closed bramski closed 1 year ago

bramski commented 1 year ago

Adds an index.d.ts file which declares all the types for this library.

bramski commented 1 year ago

@olivierkaisin @olivierkaisin-dev @tremby @emilevictorportenart Can you comment or merge this please?

tremby commented 1 year ago

Oh fancy seeing you here :) How's it going Bram?

I don't have time to dig and properly review, but it looks like it undoes the tiny change I made in #5.

bramski commented 1 year ago

Yeah pretty good! @tremby Yeah I ran into this same guy's issue: https://github.com/marker-io/browser-sdk/issues/13

When trying to use this library.

olivierkaisin commented 1 year ago

@bramski @tremby

I apologize for the long wait, our development team is currently very busy and we are doing our best to meet our users' expectations.

We are currently rewriting the package in Typescript based on the typings provided by @bramski, the package is almost ready to be released. Thank you for your help!

Would you mind giving a try to the newly published version 0.13.0-beta.0 and tell me if it works properly for you too?

tremby commented 1 year ago

I'm not in a position to properly test right now but judging from the published files and package.json it looks like it'd import into an ES6 project just fine, so I believe my needs from over in #5 are covered.

Colour me impressed at the quick response to Bram throwing some types your way!

olivierkaisin commented 1 year ago

Hi, we implemented typings based on your suggestion and improved overall compatibility with JS bundlers in https://github.com/marker-io/browser-sdk/pull/15.

I hope this solves your issue!