search

markerikson / joplin-plugin-vscode-style-search

A Joplin plugin that provides a search UI panel patterned after VS Code, with matches per note and per-match hit highlighting
20 stars 2 forks source link

Suggestions for improvement #7

Open kacnje opened 3 weeks ago

kacnje commented 3 weeks ago

After some days using plugin v0.2.2 I have some small suggestions for improvement.

  1. The shortcut CTRL+SHIFT+F is quite clumsy (at least for me). I'm sure I'm not alone :-) Can you add a setting for this?
  2. Can you add X on top right corner for closing?
  3. Default searching works inside the notes. There is a checkbox for searching in titles ("Search in titles only"). I often search for a string inside a note OR in a title. Can you add a way to search both at once?
  4. I have a version number v0.2.2, but in "Releases" I see v0.2.1. Check to avoid problems in the future.
markerikson commented 3 weeks ago

Per the version number, I had an issue with the 0.2.1 release and had to put out 0.2.2 as a quick fix.

What would you want as far as a shortcut? CTRL-SHIFT-F is the standard shortcut for "Search In All Files" in VS Code, so that's why I used it here.

kacnje commented 3 weeks ago

I understand that the current shortcut is the standard in VS Code (even if don't use it :-)). It would be nice to have a setting for a shortcut per choice.

markerikson commented 3 weeks ago

Realistically that's not something I'd plan on adding myself. I've got enough other responsibilities that working on this search plugin is low priority, and the main thing that's needed atm is more efficient searching and pagination, so that's likely what I'd try to improve next time I can actually work on it.

That said, genuinely open to improvement PRs if you or anyone else wants to try working on the code!

kacnje commented 3 weeks ago

I understand. I'm not a programmer (anymore), but maybe someone may help.

If you will have time, take a look at least for a search both in notes AND in titles with one search.