search

markerikson / marks-dev-blog-comments

Comments for my blog
4 stars 0 forks source link

Practical Redux, Part 10: Managing Modals and Context Menus #19

Open markerikson opened 4 years ago

markerikson commented 4 years ago

Original author: Waltari10 @Waltari10
Original date: 2017-08-02T09:40:21Z

Hey, i'm having a hard time rendering multiple modals. I have my array of modal descriptions in the state. I map them into an array, but only the first one gets rendered. I read online that React had actually removed support for multiple modals at the same time. Is this true?

markerikson commented 4 years ago

Original author: Norman Klein @normanklein
Original date: 2017-08-28T17:26:03Z

Thank you so much for this series of tutorials... Really, really great stuff. Sincerely hope you're taking a well-deserved vacation and you'll start this series back up again. If not, then thanks for all the fish!! as it was delicious...

markerikson commented 4 years ago

Original date: 2017-08-29T03:25:59Z

Thanks, glad to hear the series has been helpful!

I'm definitely not done - I've got quite a few more topics I want to cover. However, I've got a few other side projects that will be occupying my time in the immediate near future, including preparing for my first-ever conference talk at React Boston in September. My blogging approach is definitely on the "quality over quantity/frequency" side - I wish I had time to put up posts more regularly, but got too much going on :) Keep an eye on the blog and my Twitter for updates!

markerikson commented 4 years ago

Original author: Gadzhimari Kachaev @gadzhimari
Original date: 2018-08-26T13:10:57Z

What do you do if we have async operations before closing modal when clicked on OK button. Should we add inside our implementation Dialog class new method which care about self closing after promise resolved or something else.

markerikson commented 4 years ago

Original author: abdul aleem
Original date: 2019-10-22T18:06:48Z

Hi I am unable to find the modalConstants and modalActions javascript files, can you please provide me where can I find them, its a problem, in reading articles, I am learning from the scratch, if so I would like to have all the files that are imported in the application. I am getting error because of those things and how would I know what should I use in those files?

markerikson commented 4 years ago

Original author: abdul aleem
Original date: 2019-10-22T20:24:57Z

Many people who try to read and implement your examples, they might be starting from scratch, it would be better if the bloggers post all the code, now your code is giving me errors for modalConstants and modalActions and what are the constants IDK. Why do bloggers leave incomplete code over the internet that makes me feel sad, my time and energy is in vein if I read something which I can not copy and paste and make it run. Can you please help me by giving the code for those two modalConstants and modalActions js/jsx files?

markerikson commented 4 years ago

Original date: 2019-10-22T22:55:42Z

The complete source code for the tutorial is in a repo that is linked at the top of the page:

https://github.com/markerik...

The specific changes for this commit are here:

https://github.com/markerik...

Please read more carefully next time :)

markerikson commented 4 years ago

Original author: jason
Original date: 2020-07-28T15:31:53Z

There is one "flaw" that I cannot seem to overcome with the method of passing props to the modal during dispatch: what if the state that those props were derived from had changed at some point? Since we only pass props once, the modal won't know of any changes and thus won't re-render to reflect those changes.

vmalay commented 2 years ago

Hello, I have noticed the same issue than jason. How do you update the state of your Modal ?