search

marketing-factory / oauth2

Generic OAuth2 authentication and authorization for TYPO3 CMS
Other
9 stars 18 forks source link

Mark conflict with league/oauth2-client 2.4 #6

Closed codemonkey1988 closed 6 years ago

codemonkey1988 commented 6 years ago

There is currently an issue with current version of omines/oauth2-gitlab and the newly released version of league/oauth2-client 2.4.

Argument Type in AbstractProvider::getResourceOwnerDetailsUrl changed from AccessToken to AccessTokenInterface with breaks the inheritance currently.

This change can be reverted as soon as omines/oauth2-gitlab releases a new compatible version.

codemonkey1988 commented 6 years ago

See issue https://github.com/omines/oauth2-gitlab/issues/6

curry684 commented 6 years ago

Not going to merge this and make a release for one day if either you or I can also just fix it this weekend 😉

curry684 commented 6 years ago

Oh nm me thought this was a PR on ours hehe. If you issue a fixing PR on our end I should be able to review, merge and release tomorrow night.

codemonkey1988 commented 6 years ago

I can provide a PR later today (I think at about midnight)

codemonkey1988 commented 6 years ago

This PR can be closed in favour of https://github.com/omines/oauth2-gitlab/pull/7

curry684 commented 6 years ago

https://github.com/omines/oauth2-gitlab/releases/tag/3.1.2