search

marketvision / ShipStation4Net

A .NET Standard Library using System.Net.HttpClient and NewtonSoft.Json which provides access to the ShipStation API.
Apache License 2.0
8 stars 12 forks source link

Added support for retreving webhook payloads. As ShipStation uses a… #20

Closed aceven24 closed 4 years ago

aceven24 commented 4 years ago

… resourceURL/callback pattern to actually get the webhook data opposed to having it in payload

https://help.shipstation.com/hc/en-us/articles/360025856252-ShipStation-Webhooks

I couldn't really come up with tests as ShipStation doesn't provide sample payloads, but according to their documentation it mimics the ListOrders and ListShipments.

mv-vlad-kurdesov commented 4 years ago

looks good. i will apply couple tweaks and add release notes and merge to master shortly.. for now, i will merge to new branch on our repo so that i can add changes before merge to master..

mv-vlad-kurdesov commented 4 years ago

merged to master. changes should be included in package version 0.10.73 which should be built shortly via CI

couple tweaks I added on top of your changes could be found in this commit - https://github.com/marketvision/ShipStation4Net/commit/dce9c5c81a8072e20feca1ec4ec656c177c740ba

i switched implementation of GetResourceResponsesAsync to use GetAllPagesAsync with resourceUrl for both clients - orders & shipments

I also tested my changes against shipstation account & verified that methods still work for all 4 webhook types.