Shipments.VoidLabelAsync return value issue

marketvision / ShipStation4Net

A .NET Standard Library using System.Net.HttpClient and NewtonSoft.Json which provides access to the ShipStation API.

Apache License 2.0

8 stars 12 forks source link

Closed umedbisht closed 2 years ago

umedbisht commented 2 years ago

ShipStation API returns

{ "approved": true, "message": "Label voided successfully" }

But VoidLabelAsync method is using SuccessResponse as response

{ "success": true, "message": "The requested order has been deleted." }

Due to "approved" vs "success" property difference, this method will always result false even though given label is Voided.

mv-vlad-kurdesov commented 2 years ago

changes were approved and merged #34 package 1.0.3 should be on nuget soon