Firefox strategie lacks of socks protocol support

[GoogleCodeExporter]

What steps will reproduce the problem?
1. ps.select(new URI("socks://host:port"))
2.
3.

What is the expected output? What do you see instead?
expected: SOCKS proxy see: DIRECT

What version of the product are you using? On what operating system?
latest on Win platform

Please provide any additional information below.
FirefoxProxySearchStrategy => miss socks management

attached corrected version

Original issue reported on code.google.com by giam...@gmail.com on 20 Apr 2011 at 4:03

Attachments:

• FirefoxProxySearchStrategy.java

[GoogleCodeExporter]

Hi,
I will have a look at this. I applied your patch with some small modification 
to use a Proxy.SOCKS proxy instead of a Proxy.HTTP proxy. 

This modification is already in the respository. I will do some more testing on 
this and then this will make it into the next release.

Thanks for reporting this. I just forgot to implement this feature.

Have fun,
- Rossi

Original comment by rosstaus...@googlemail.com on 20 Apr 2011 at 8:22

• Changed state: Accepted

[GoogleCodeExporter]

Hi, thank you, 

in my implementation I also added the check for setting socks only proxy and 
other fields blank.

bye

Original comment by giam...@gmail.com on 21 Apr 2011 at 9:23

[GoogleCodeExporter]

Hi,
Yes thats a good point. I improved the settings parser. It will now set all the 
proxies available even if some fields are blank.

So it is now possible to use only a Socks proxy with no HTTP proxy set.
The changes are in the repository. Thanks for your good input.

Have fun,
- Rossi

Original comment by rosstaus...@googlemail.com on 21 Apr 2011 at 6:54

• Changed state: Fixed