search

markewiseman / proxy-vole

Automatically exported from code.google.com/p/proxy-vole
0 stars 0 forks source link

JavaProxySearchStrategy only enabled with HTTP system properties given #58

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

1. specify HTTPS, FTP, ... java proxy properties only, but no HTTP ones
2. try to use the JavaProxySearchStrategy

What is the expected output? What do you see instead?

expected: non-null ProxySelector instance returned from 
JavaProxySearchStrategy#getProxySelector()

actual: null due to #proxyPropertyPresent() method testing only for HTTP proxy 
system properties.

What version of the product are you using? On what operating system?

20131209

Please provide any additional information below.

This should be a rare problem. Happened for me only while testing and being 
lazy for system properties specification then, I knew that there will be only 
HTTPS accesses.

Original issue reported on code.google.com by jpsta...@gmail.com on 2 Apr 2015 at 3:27

GoogleCodeExporter commented 8 years ago 
I found this annoying as sometimes I only want to set a SOCKS proxy and not an 
HTTP proxy.  I changed proxyPropertyPresent() to return true if http.proxyHost 
OR https.proxyHost OR socksProxyHost is set.

Original comment by rscsr...@gmail.com on 8 Jun 2015 at 2:29