markfairbanks / tidypolars

Tidy interface to polars
http://tidypolars.readthedocs.io
MIT License
337 stars 11 forks source link

Error when using .arrange() #233

Closed GarronG closed 1 week ago

GarronG commented 8 months ago

As an avid user of tidyverse, and a newcomer to Python I'm so excited to have discovered tidypolars! I just tried out a simple example below, but I am getting the error message. I am using python 3.9.17 on Windows 10 X64 PC.

import tidypolars as tp from tidypolars import col, desc df = tp.Tibble(x = range(3), y = range(3, 6), z = ['a', 'a', 'b']) df.arrange('x')

Error message:

TypeError Traceback (most recent call last) Cell In[9], line 5 3 from tidypolars import col, desc 4 df = tp.Tibble(x = range(3), y = range(3, 6), z = ['a', 'a', 'b']) ----> 5 df.arrange('x')

File H:\share\Texas\Garron\py3917\lib\site-packages\tidypolars\tibble.py:102, in Tibble.arrange(self, *args) 100 exprs = _as_list(args) 101 desc = [True if isinstance(expr, DescCol) else False for expr in exprs] --> 102 return super().sort(exprs, reverse = desc).pipe(from_polars)

TypeError: sort() got an unexpected keyword argument 'reverse'

markfairbanks commented 8 months ago

polars has been implementing changes (and breaking changes) faster than I can keep up with. Changing reverse to descending in .sort() was one of them. It's good that polars is constantly improving, but the API instability makes it a bit hard to build a package that depends on it.

There are probably a lot more fixes necessary to get tidypolars back to a good state. I'll try to get to them at some point, but between a newborn and a new job I'm bit behind on keeping this package up to date. I've only had enough time lately to keep updates to R's tidytable and dtplyr.

Unfortunately that means for for the foreseeable future tidypolars is a "broken" package. I am waiting for a polars v1.0.0 release so I can be sure it is more stable before reviving tidypolars.