Closed mjkarlsen closed 2 years ago
Fixed the tests. They must not have been running since they were misnamed. I had to use select/arrange so everything was consistently ordered.
I also added an if
statement so that it only uses fill_null
when a fill value is provided.
I'm not 100% used to the values_fill
functionality, so I'll leave it up to you that it matches tidyverse semantics.
Can you also take a look at the tests for pivot_wider? I tried to rename tets_pivot_wider but it threw a bunch of errors whenever I ran pytests.