markfairbanks / tidytable

Tidy interface to 'data.table'
https://markfairbanks.github.io/tidytable/
Other
450 stars 32 forks source link

Retheming the docs #164

Closed moutikabdessabour closed 3 years ago

moutikabdessabour commented 3 years ago

Can you give me your feedback on the new "site", I can remove the burgundy I was just trying to see how it looks. Also thanks for the warning on the speed comparaisons, I managed to disable the chunks by setting the global knitr options eval=F. Also I can find the original logo png I want to make it transparent so the README will look nicer in github's dark theme.

Nevermind the logo question I managed to find it. Can you link me the tool u used to create the favicons I saw one in an rstudio thread but I can manage to find it now

markfairbanks commented 3 years ago

The site looks good! I agree with you, I think it will look good once the burgundy is black.

As far as favicons - you just need to run pkgdown::build_favicons() and it will build it from the logo

markfairbanks commented 3 years ago

Before you make a PR, I figure I'll go take a look at some theme options. What was the name of the theme you're using here?

moutikabdessabour commented 3 years ago

I'm using bootswatch's paper theme with some customization in pkgdown/extra.css, I still didn't push the black styled one. Also I added a line in README.Rmd to directly get the dev version from the DESCRIPTION file

moutikabdessabour commented 3 years ago

@markfairbanks Now I'm ready to make a PR. here is a list of the available themes

markfairbanks commented 3 years ago

Sounds good, send it over whenever you're ready

markfairbanks commented 3 years ago

Actually - I know you mentioned that you are doing some customizations. Is it possible to make the normal font just a point bigger? (Titles look like they're the right size). Might make it look weird, but it'd be interesting to see.

If it seems like a pain to do no worries, you can make the pull request as is.

moutikabdessabour commented 3 years ago

I made them bigger, if there is any changes that you'd like to see just let me know

markfairbanks commented 3 years ago

My bad I meant the normal font, not the headers.

Want to make a PR after two things are changed:

Thanks again for all the work on this! The site looks much better 👍

moutikabdessabour commented 3 years ago

I think I made the font bigger probably bigger than what you wanted. Can you check. It was 13px I changed it to 16px do you want the text to be the same size it was on the old website 14px? Also if you think that github README font-size for headers and normal text is ok I can reproduce it in css.

markfairbanks commented 3 years ago

Hmm yeah I think 16px is a bit large. 14px should be good. Can we increase the code font to 14px as well? It looks like it stayed at 13px.

The font-size for headers is good now.

moutikabdessabour commented 3 years ago

font size 13px : 13px font size 14px : 14px I think 13px blends in nicely with the other content, previous size was 12px

markfairbanks commented 3 years ago

I think 13px blends in nicely with the other content

Yep, I agree. Looks good